fix(transcribe): warn when optional captions are skipped#2315
Open
miguel-heygen wants to merge 1 commit into
Open
fix(transcribe): warn when optional captions are skipped#2315miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whisper_unavailablewarning on stderr whentranscribe --optional --jsonskips captionswhisper-bin-x64.zipbefore the CMake fallbackRegression
A Windows feedback report showed
transcribe --optionalexiting 0 without any stderr diagnostic when whisper-cpp was unavailable, allowing pipelines that suppress successful stdout to ship captionless output silently.Tests
bunx vitest run src/commands/transcribe.test.ts src/whisper/manager.test.tsbun run --filter @hyperframes/cli typecheckbunx oxlint packages/cli/src/commands/transcribe.ts packages/cli/src/commands/transcribe.test.ts packages/cli/src/whisper/manager.ts packages/cli/src/whisper/manager.test.ts